Re: [Xen-devel] [PATCH v5 08/13] x86/traps: factor out pv_trap_init

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/06/17 19:19, Jan Beulich wrote:
>>>> Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 06/27/17 8:06 PM >>>
>> On 26/06/17 17:28, Wei Liu wrote:
>>> --- a/xen/arch/x86/traps.c
>>> +++ b/xen/arch/x86/traps.c
>>> @@ -1934,21 +1934,29 @@ void __init init_idt_traps(void)
>>>      this_cpu(compat_gdt_table) = boot_cpu_compat_gdt_table;
>>>  }
>>>  
>>> +void __init pv_trap_init(void)
>>> +{
>>> +    /* The 32-on-64 hypercall vector is only accessible from ring 1. */
>>> +    _set_gate(idt_table + HYPERCALL_VECTOR,
>> &idt_table[HYPERCALL_VECTOR]
> I don't think we should require this. Personally I prefer the form Wei used,
> and iirc there's nothing in our coding style guidelines that mandates the
> form you suggest.

One form is obviously an array access, while one is not obvious.

I'm not overly fussed, but I would prefer the former.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel