Re: [Xen-devel] [PATCH 1/8] x86/irq.c: use plain bool

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/06/17 15:18, Wei Liu wrote:
> Replace bool_t with bool and adjust code accordingly.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/arch/x86/irq.c | 25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
> index 113667cdea..32800ce165 100644
> --- a/xen/arch/x86/irq.c
> +++ b/xen/arch/x86/irq.c
> @@ -29,7 +29,7 @@
>  static void parse_irq_vector_map_param(char *s);
>  
>  /* opt_noirqbalance: If true, software IRQ balancing/affinity is disabled. */
> -bool_t __read_mostly opt_noirqbalance = 0;
> +bool __read_mostly opt_noirqbalance;
>  boolean_param("noirqbalance", opt_noirqbalance);
>  
>  unsigned int __read_mostly nr_irqs_gsi = 16;
> @@ -1070,7 +1070,7 @@ struct pending_eoi {
>  static DEFINE_PER_CPU(struct pending_eoi, pending_eoi[NR_DYNAMIC_VECTORS]);
>  #define pending_eoi_sp(p) ((p)[NR_DYNAMIC_VECTORS-1].vector)
>  
> -bool_t cpu_has_pending_apic_eoi(void)
> +bool cpu_has_pending_apic_eoi(void)
>  {
>      return (pending_eoi_sp(this_cpu(pending_eoi)) != 0);
>  }

This function has a prototype which needs changing.  On the style side,
you can drop the brackets here as well.

> @@ -1802,11 +1802,12 @@ void pirq_guest_unbind(struct domain *d, struct pirq 
> *pirq)
>          cleanup_domain_irq_pirq(d, irq, pirq);
>  }
>  
> -static int pirq_guest_force_unbind(struct domain *d, struct pirq *pirq)
> +static bool pirq_guest_force_unbind(struct domain *d, struct pirq *pirq)
>  {
>      struct irq_desc *desc;
>      irq_guest_action_t *action, *oldaction = NULL;
> -    int i, bound = 0;
> +    int i;
> +    bool bound = false;
>  
>      WARN_ON(!spin_is_locked(&d->event_lock));
>  
> @@ -1830,7 +1831,7 @@ static int pirq_guest_force_unbind(struct domain *d, 
> struct pirq *pirq)
>      if ( i == action->nr_guests )
>          goto out;
>  
> -    bound = 1;
> +    bound = true;
>      oldaction = __pirq_guest_unbind(d, pirq, desc);
>  
>   out:
> @@ -1846,8 +1847,8 @@ static int pirq_guest_force_unbind(struct domain *d, 
> struct pirq *pirq)
>      return bound;
>  }
>  
> -static inline bool_t is_free_pirq(const struct domain *d,
> -                                  const struct pirq *pirq)
> +static inline bool is_free_pirq(const struct domain *d,
> +                                const struct pirq *pirq)
>  {
>      return !pirq || (!pirq->arch.irq && (!is_hvm_domain(d) ||
>          pirq->arch.hvm.emuirq == IRQ_UNBOUND));
> @@ -2098,7 +2099,7 @@ int unmap_domain_pirq(struct domain *d, int pirq)
>      struct irq_desc *desc;
>      int irq, ret = 0, rc;
>      unsigned int i, nr = 1;
> -    bool_t forced_unbind;
> +    bool forced_unbind;
>      struct pirq *info;
>      struct msi_desc *msi_desc = NULL;
>  
> @@ -2327,7 +2328,7 @@ static int __init setup_dump_irqs(void)
>  __initcall(setup_dump_irqs);
>  
>  /* Reset irq affinities to match the given CPU mask. */
> -void fixup_irqs(const cpumask_t *mask, bool_t verbose)
> +void fixup_irqs(const cpumask_t *mask, bool verbose)

Same with the prototype here.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel