Re: [Xen-devel] [PATCH v3 01/11] libxl: add vdispl structures to idl

[Oleksandr Grytsov <al1img@xxxxxxxxx>]

Hi Wei,

Thanks for the review.

This field is already defined in the display protocol.
To avoid misunderstanding I prefer to use same name in libxl
as well.



On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Jun 27, 2017 at 01:03:17PM +0300, Oleksandr Grytsov wrote:
>> From: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
>>
>> Add libxl_device_vdispl and libxl_vdisplinfo to libxl_types.idl
>> Add VDISPL to libxl__device_kind enumerator
>>
>> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
>> ---
>>  tools/libxl/libxl_types.idl          | 38 
>> +++++++++++++++++++++++++++++++++++-
>>  tools/libxl/libxl_types_internal.idl |  1 +
>>  2 files changed, 38 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
>> index 2204425..25563cf 100644
>> --- a/tools/libxl/libxl_types.idl
>> +++ b/tools/libxl/libxl_types.idl
>> @@ -755,7 +755,21 @@ libxl_device_vtpm = Struct("device_vtpm", [
>>      ("backend_domname",  string),
>>      ("devid",            libxl_devid),
>>      ("uuid",             libxl_uuid),
>> -])
>> +    ])
>> +
>> +libxl_connector_param = Struct("connector_param", [
>> +    ("id", string),
>> +    ("width", uint32),
>> +    ("height", uint32)
>> +    ])
>> +
>> +libxl_device_vdispl = Struct("device_vdispl", [
>> +    ("backend_domid", libxl_domid),
>> +    ("backend_domname", string),
>> +    ("devid", libxl_devid),
>> +    ("be_alloc", bool),
>
> After reading the doc -- use "allocator" for this field?



-- 
Best Regards,
Oleksandr Grytsov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel