[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v12 15/23] x86: refactor psr: CDP: implement set value callback function.
- To: <yi.y.sun@xxxxxxxxxxxxxxx>
- From: "Jan Beulich" <jbeulich@xxxxxxxx>
- Date: Fri, 30 Jun 2017 06:02:32 -0600
- Cc: kevin.tian@xxxxxxxxx, wei.liu2@xxxxxxxxxx, he.chen@xxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, dario.faggioli@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, mengxu@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx, roger.pau@xxxxxxxxxx
- Delivery-date: Fri, 30 Jun 2017 12:02:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
>>> Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> 06/30/17 1:30 PM >>>
>The input 'type' is CODE. The props->type[0] is DATA and props->type[1] is
>CODE.
>In the first iteration, the props->type[0] is DATA so that it does not match
>'type' and the second check is false too. If we use else branch here, it will
>enter the branch and return -EVINVAL. But this is not we want, right? We hope
>the second iteration should be executed to set CODE.
I see. That'll then call for yet another solution; I don't think the code should
stay as is.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
