Re: [Xen-devel] [PATCH v5 02/12] arm/mem_access: Move PAGE_SHIFT_* macros to lib.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.17 at 11:03, <proskurin@xxxxxxxxxxxxx> wrote:
> To prevent potential type width issues with ARMv7, I would reuse the
> macro from xen/iommu.h at this point:
> 
> PAGE_MASK_GRAN(sz)                     (~(u64)0 << PAGE_SHIFT_##sz)

Seems reasonable, except
- no new use of u64 please (use uint64_t instead)
- it's questionable whether a 64-bit type here is correct in the
  first place, especially when considering 32-bit architectures

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel