Re: [Xen-devel] [PATCH v3 04/11] libxl: add generic function to add device

[Oleksandr Grytsov <al1img@xxxxxxxxx>]

On Fri, Jun 30, 2017 at 5:18 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, Jun 30, 2017 at 03:16:38PM +0100, Wei Liu wrote:
>> On Fri, Jun 30, 2017 at 04:24:23PM +0300, Oleksandr Grytsov wrote:
>> > On Thu, Jun 29, 2017 at 8:36 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
>> > > On Tue, Jun 27, 2017 at 01:03:20PM +0300, Oleksandr Grytsov wrote:
>> > >> From: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
>> > >>
>> > >> Add libxl__device_add functio.
>> > >
>> > > function
>> > >
>> > >> Almost all devices have similar libxl__device_xxxx_add function.
>> > >> This generic function implements same functionality but
>> > >> using the device handling framework. The device specific
>> > >> part this is setting xen store configuration. This part
>> > >> is moved to set_xenstore_config callback of the device framework.
>> > >>
>> > >
>> > > Right. I think this is a good idea in general.
>> > >
>> > > I don't see exiting device ported to the new framework, why?
>> >
>> > Good question. I think it is a little dangerous and may introduce 
>> > regression.
>> > But definitely it should be done. I can do these changes but I don't have
>> > visibility how to check each device.
>>
>> Please just do it. We have a lot of time during development and RC
>> period for people to test your changes.
>
> And I forget to say, please use one patch for one device type.

Should it be in this patch set or better to create new one for each device?

-- 
Best Regards,
Oleksandr Grytsov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel