Re: [Xen-devel] [PATCH 1/25] VIOMMU: Add vIOMMU helper functions to create, destroy and query capabilities

[Lan Tianyu <tianyu.lan@xxxxxxxxx>]

On 2017年07月04日 15:55, Jan Beulich wrote:
>>>> On 04.07.17 at 03:46, <tianyu.lan@xxxxxxxxx> wrote:
>> On 2017年06月30日 21:05, Wei Liu wrote:
>>> On Thu, Jun 29, 2017 at 01:50:33AM -0400, Lan Tianyu wrote:
>>> [...]
>>>>> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
>>>>> index dc8e876..8ba4f5a 100644
>>>>> --- a/xen/common/Kconfig
>>>>> +++ b/xen/common/Kconfig
>>>>> @@ -73,6 +73,18 @@ config TMEM
>>>>>  
>>>>>     If unsure, say Y.
>>>>>  
>>>>> +config VIOMMU
>>>>> + def_bool y
>>>>> + depends on X86
>>> This depends on x86 but the code is in common/. What's the game plan /
>>> expectation here?
>>>
>> The code is general but so far only x86 uses the vIOMMU framework
>> and Julien hope it is disabled on ARM. So only build in vIOMMU codes on x86.
> 
> When there's no prompt, I think the better approach would be for
> the option to just be "bool" and there to be a per-arch "select".
> That way, even if we supported more than two arches you'd
> avoid the "depends" here eventually becoming quite clumsy.
> 
> Jan
> 

How about following changes?

xen/common/Kconfig:
config VIOMMU
        bool
        ---help---
          Virtual IOMMU provides interrupt remapping function for guest and it
allows guest to boot up more than 255 vcpus which requires
interrupt remapping function.

          You also have to enable it on the Xen commandline by using viommu=1

          If unsure, say Y.



xen/arch/x86/Kconfig:
config X86
        def_bool y
        select ACPI
        select ACPI_LEGACY_TABLES_LOOKUP
        ...
        select HAS_PCI
        select HAS_PDX
        select NUMA
        select VGA
+       select VIOMMU



-- 
Best regards
Tianyu Lan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel