[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1 3/6] vmx: refactor vmx_init_vmcs_config()
>>> On 26.06.17 at 12:44, <sergey.dyasli@xxxxxxxxxx> wrote: > --- a/xen/arch/x86/hvm/vmx/vmcs.c > +++ b/xen/arch/x86/hvm/vmx/vmcs.c > @@ -227,7 +227,8 @@ static u32 adjust_vmx_controls( > { > u32 vmx_msr_low, vmx_msr_high, ctl = ctl_min | ctl_opt; > > - rdmsr(msr, vmx_msr_low, vmx_msr_high); > + vmx_msr_low = raw_vmx_msr_policy.msr[msr - MSR_IA32_VMX_BASIC]; > + vmx_msr_high = raw_vmx_msr_policy.msr[msr - MSR_IA32_VMX_BASIC] >> 32; Please consider adding a helper macro or inline function for the raw_vmx_msr_policy.msr[msr - MSR_IA32_VMX_BASIC] sub-expression (which likely is going to be usable elsewhere too, e.g. in patch 2). > @@ -632,8 +628,8 @@ int vmx_cpu_up(void) > * the requred CRO fixed bits in VMX operation. > */ > cr0 = read_cr0(); > - rdmsrl(MSR_IA32_VMX_CR0_FIXED0, vmx_cr0_fixed0); > - rdmsrl(MSR_IA32_VMX_CR0_FIXED1, vmx_cr0_fixed1); > + vmx_cr0_fixed0 = raw_vmx_msr_policy.cr0_fixed_0.raw; > + vmx_cr0_fixed1 = raw_vmx_msr_policy.cr0_fixed_1.raw; Ah, here comes the change I did ask for. Judging from the title I wasn't able to guess that, and I really don't mind in which of the patches it happens. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |