Re: [Xen-devel] [PATCH 1/7] xen/arm: SMMU: Implement the add_device callback in SMMU

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 06/30/2017 04:15 AM, Wei Chen wrote:
> This add_device callback function is taking care of adding a device
> to SMMU and make sure it is fully prepare to be used by the SMMU
> afterwards.
>
> In previous code, we don't implement the add_device callback in
> iommu_ops for ARM SMMU. We placed the work of add_device to
> assign_device callback. The function assign_device should not care
> about adding the device to an iommu_group. It might not even be
> able to decide how to do that. In this patch, we move this work
> back to add_device callback.
>
> This add_device callback is only called while we are handling all
> devices for constructing the Domain0.
>
> Signed-off-by: Wei Chen <Wei.Chen@xxxxxxx>
> ---
>   xen/drivers/passthrough/arm/smmu.c | 34 +++++++++++++++++++++++-----------
>   1 file changed, 23 insertions(+), 11 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/smmu.c 
> b/xen/drivers/passthrough/arm/smmu.c
> index 74c09b0..2efa52d 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2591,6 +2591,26 @@ static void arm_smmu_destroy_iommu_domain(struct 
> iommu_domain *domain)
>         xfree(domain);
>   }
>   
> +static int arm_smmu_xen_add_device(u8 devfn, struct device*dev)
Coding style: struct device *dev

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel