Re: [Xen-devel] [PATCH v5 04/12] arm/lpae: Introduce lpae_page helper

[Julien Grall <julien.grall@xxxxxxx>]

On 05/07/17 14:11, Sergej Proskurin wrote:
> Hi Julien,
>
>
> On 07/04/2017 06:23 PM, Julien Grall wrote:
> > Hi Sergej,
> >
> > On 06/27/2017 12:52 PM, Sergej Proskurin wrote:
> > > This commit introduces a new helper that checks whether the target PTE
> > > holds a page mapping or not. This helper will be used as part of the
> > > following commits.
> > >
> > > Signed-off-by: Sergej Proskurin <proskurin@xxxxxxxxxxxxx>
> > Reviewed-by: Julien Grall <julien.grall@xxxxxxx>
> >
> > Cheers,
> >
> > > ---
> > > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > > Cc: Julien Grall <julien.grall@xxxxxxx>
> > > ---
> > >   xen/include/asm-arm/lpae.h | 5 +++++
> > >   1 file changed, 5 insertions(+)
> > >
> > > diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h
> > > index 2f7891ed0b..20565d2c8a 100644
> > > --- a/xen/include/asm-arm/lpae.h
> > > +++ b/xen/include/asm-arm/lpae.h
> > > @@ -153,6 +153,11 @@ static inline bool lpae_is_superpage(lpae_t pte,
> > > unsigned int level)
> > >       return (level < 3) && lpae_mapping(pte);
> > >   }
> > >   +static inline bool lpae_page(lpae_t pte, unsigned int level)
> > > +{
> > > +    return (level == 3) && lpae_valid(pte) && pte.walk.table;
> > > +}
> > > +
> > >   /*
> > >    * The ARMv8 architecture supports pages with different sizes (4K,
> > > 16K, and
> > >    * 64K). To enable guest page table walks for various
> > > configurations, the
> Would that be ok for you if I changed the name of the helper lpae_page
> into lpae_is_page as to be conform with lpae_is_superpage or shall I
> remove your Reviewed-by for doing this? Thanks.
I am fine with that.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel