Re: [Xen-devel] [PATCH v13 16/23] x86: L2 CAT: implement CPU init flow.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> 07/06/17 4:07 AM >>>
>This patch implements the CPU init flow for L2 CAT.
>
>Note: L2 CAT does NOT work until you apply the later patches of L2 CAT.
>"x86: L2 CAT: implement get hw info flow."
>"x86: L2 CAT: implement get value flow."
>"x86: L2 CAT: implement set value flow."

Same comment as on the respective CDP one.

>@@ -269,6 +271,12 @@ static bool psr_check_cbm(unsigned int cbm_len, unsigned 
>long cbm)
 >}
 >
 >/* CAT common functions implementation. */
>+static char *feat_name[FEAT_TYPE_NUM] = {

const char * const

Additionally - do you need or plan to use this in more than one function? If
not, it should be made local to its only user. If so, the variable name should
include "cat", as these appear to be CAT-specific feature names only.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel