Re: [Xen-devel] [PATCH] hvmloader, libxl: use the correct ACPI settings depending on device model

[Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>]

On 25/07/17 15:33, Wei Liu wrote:
> On Wed, Jul 19, 2017 at 10:19:35PM +0100, Igor Druzhinin wrote:
>> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
>> index 1158303..8dc8186 100644
>> --- a/tools/libxl/libxl_create.c
>> +++ b/tools/libxl/libxl_create.c
>> @@ -472,6 +472,8 @@ int libxl__domain_build(libxl__gc *gc,
>>                                     info->u.hvm.mmio_hole_memkb << 10);
>>              }
>>          }
>> +        localents[i++] = "platform/device-model";
>> +        localents[i++] = (char *) 
>> libxl_device_model_version_to_string(info->device_model_version);
> 
> You probably want to enlarge localents array so that it can accommodate
> the new elements.
> 

Good catch, for some reason I thought it's already preallocated big
enough. It looks like somebody before me made the same mistake as it's
already small enough to hold all the items.

Igor

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel