Re: [Xen-devel] [PATCH] xen:arm earlyprintk configuration for Hikey 960 boards

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 26 Jul 2017, Julien Grall wrote:
> Hi Konrad,
> 
> On 26/07/17 17:54, Konrad Rzeszutek Wilk wrote:
> > Introduce an earlyprintk configuration of Hikey 960 boards.
> > 
> > Tested with:
> >  https://github.com/96boards-hikey/edk2.git #testing/hikey960_v2.5
> >  https://github.com/96boards-hikey/OpenPlatformPkg.git
> > #testing/hikey960_v1.3.4
> >  https://git.savannah.gnu.org/git/grub.git #master
> >  https://github.com/96boards-hikey/linux.git #hikey960-upstream-rebase
> > 
> > For GRUB, the following stanza was used:
> > 
> > GRUB_MODULES="boot chain configfile echo efinet eval ext2 fat font gettext
> > gfxterm gzio help linux loadenv lsefi normal part_gpt par
> > t_msdos read regexp search search_fs_file search_fs_uuid search_label
> > terminal terminfo test tftp time xen_boot"
> > 
> > grub-install/usr/bin/grub-mkimage \
> >                 --config grub.config \
> >                 --dtb
> > linux/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dtb \
> >                 --directory=grub/usr/lib64/grub/arm64-efi \
> >                 --output=grubaa64.efi \
> >                 --format=arm64-efi \
> >                 --prefix="/boot/grub" \
> >                 $GRUB_MODULES
> > 
> > And grub.config:
> > search.fs_label rootfs root
> > 
> > set prefix=($root)/boot/grub
> > configfile $prefix/grub.cfg
> 
> Would it be possible to update the wiki page on the hikey [1] with your latest
> finding?
> 
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
> > ---
> >  docs/misc/arm/early-printk.txt | 1 +
> >  xen/arch/arm/Rules.mk          | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
> > index 41b528b9fa..61c5ad9eac 100644
> > --- a/docs/misc/arm/early-printk.txt
> > +++ b/docs/misc/arm/early-printk.txt
> > @@ -49,6 +49,7 @@ the name of the machine:
> >    - xgene-mcdivitt: printk with 820 on Xgene mcdivitt platform
> >    - xgene-storm: printk with 820 on Xgene storm platform
> >    - zynqmp: printk with Cadence UART for Xilinx ZynqMP SoCs
> > +  - hikey960: printk with pl011 with Hikey 960
> 
> Please order it alphabetically
> 
> > 
> >  These settings are is hardcoded in xen/arch/arm/Rules.mk,
> >  see there when adding support for new machines.
> > diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> > index 569a0badc8..faae29262e 100644
> > --- a/xen/arch/arm/Rules.mk
> > +++ b/xen/arch/arm/Rules.mk
> > @@ -44,6 +44,7 @@ EARLY_PRINTK_vexpress       := pl011,0x1c090000
> >  EARLY_PRINTK_xgene-mcdivitt := 8250,0x1c021000,2
> >  EARLY_PRINTK_xgene-storm    := 8250,0x1c020000,2
> >  EARLY_PRINTK_zynqmp         := cadence,0xff000000
> > +EARLY_PRINTK_hikey960       := pl011,0xfff32000
> 
> Ditto. With that:
> 
> Acked-by: Julien Grall <julien.grall@xxxxxxx>

I'll fix on commit.

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel