Re: [Xen-devel] [PATCH v4 06/13] libxl: change p9 to use generec add function

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jul 18, 2017 at 05:25:23PM +0300, Oleksandr Grytsov wrote:
[...]
>  /* Waits for the passed device to reach state XenbusStateInitWait.
>   * This is not really useful by itself, but is important when executing
>   * hotplug scripts, since we need to be sure the device is in the correct
> @@ -3565,6 +3559,7 @@ extern const struct libxl_device_type 
> libxl__usbctrl_devtype;
>  extern const struct libxl_device_type libxl__usbdev_devtype;
>  extern const struct libxl_device_type libxl__pcidev_devtype;
>  extern const struct libxl_device_type libxl__vdispl_devtype;
> +extern const struct libxl_device_type libxl__p9_devtype;
>  
>  extern const struct libxl_device_type *device_type_tbl[];
>  
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 25563cf..96dbaed 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -804,7 +804,7 @@ libxl_domain_config = Struct("domain_config", [
>      ("vfbs", Array(libxl_device_vfb, "num_vfbs")),
>      ("vkbs", Array(libxl_device_vkb, "num_vkbs")),
>      ("vtpms", Array(libxl_device_vtpm, "num_vtpms")),
> -    ("p9", Array(libxl_device_p9, "num_p9s")),
> +    ("p9s", Array(libxl_device_p9, "num_p9s")),

Oh, no, please don't do this. We can't change the name of the fields.

There is already on irregular device type -- the PCI device. I suppose
you probably need another hook somewhere. And please convert PCI devices
if you can.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel