Re: [Xen-devel] [PATCH v2] xen: Implement hypercall for tracing of program counters

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 07/28/2017 04:37 PM, Wei Liu wrote:
> On Wed, Jul 26, 2017 at 12:43:45PM +0200, Felix Schmoll wrote:
> > +        d->tracing_buffer = NULL;
> > +
> > +        if ( copy_to_guest(buf, temp, d->tracing_buffer_pos) )
> > +            ret = -EFAULT;
> > +
> > +        xfree(temp);
> > +
> > +        ret = d->tracing_buffer_pos;
> > +        break;
> > +    }
> > +
> > +    default:
> > +        ret = -ENOSYS;
> EINVAL
Should not it be -EOPNOTSUPP to match return error when CONFIG_TRACE_PC 
is not?
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel