Re: [Xen-devel] [PATCH v2 09/13] xen/arm: Add use_iommu flag to xen_arch_domainconfig

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 25/07/17 18:26, Oleksandr Tyshchenko wrote:
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index ec19310..3079bbe 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -569,7 +569,7 @@ int arch_domain_create(struct domain *d, unsigned int 
> domcr_flags,
>      ASSERT(config != NULL);
>
>      /* p2m_init relies on some value initialized by the IOMMU subsystem */
> -    if ( (rc = iommu_domain_init(d, false)) != 0 )
> +    if ( (rc = iommu_domain_init(d, !!config->use_iommu)) != 0 )
NIT: !! is not necessary as the parameter is a bool :).

Acked-by: Julien Grall <julien.grall@xxxxxxx>

>          goto fail;
>
>      if ( (rc = p2m_init(d)) != 0 )
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel