Re: [Xen-devel] [PATCH 22/25 v7] xen/arm: vpl011: Add support for vuart console in xenconsole

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Aug 07, 2017 at 02:23:14PM +0530, Bhupinder Thakur wrote:
> This patch finally adds the support for vuart console. It adds
> two new fields in the console initialization:
> 
> - optional
> - use_gnttab
> 
> optional flag tells whether the console is optional.
> 
> use_gnttab tells whether the ring buffer should be allocated using
> grant table.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> @@ -665,7 +689,9 @@ static int console_create_ring(struct console *con)
>       if (ring_ref != con->ring_ref && con->ring_ref != -1)
>               console_unmap_interface(con);
>  
> -     if (!con->interface && xgt_handle) {
> +     if (!con->interface &&
> +         xgt_handle &&
> +         con->use_gnttab) {

You can join all these to one line.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel