Re: [Xen-devel] [PATCH] common/page_alloc: Drop BOOT_BUG_ON()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/08/17 10:14, Jan Beulich wrote:
>>>> On 08.08.17 at 19:28, <andrew.cooper3@xxxxxxxxxx> wrote:
>> Regular BUG_ON()'s work fine by this point on all architectures, so drop the
>> custom infrastructure.  Substitute BUG_ON(1) for BUG().
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one question:
>
>> @@ -362,8 +355,7 @@ unsigned long __init alloc_boot_pages(
>>          return pg;
>>      }
>>  
>> -    BOOT_BUG_ON(1);
>> -    return 0;
>> +    BUG();
>>  }
> Are all versions of gcc we formally support happy with the dropped
> return?

BUG() has an unreachable() at the end of it, which is do {} while (1)
for older compilers.

We already have constructs like this sporadically over the code,
oos_snapshot_lookup() as an example.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel