Re: [Xen-devel] [PATCH v4 1/2] gnttab: don't use possibly unbounded tail calls

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/08/17 11:20, Jan Beulich wrote:
> There is no guarantee that the compiler would actually translate them
> to branches instead of calls, so only ones with a known recursion limit
> are okay:
> - __release_grant_for_copy() can call itself only once, as
>   __acquire_grant_for_copy() won't permit use of multi-level transitive
>   grants,
> - __acquire_grant_for_copy() is fine to call itself with the last
>   argument false, as that prevents further recursion,
> - __acquire_grant_for_copy() must not call itself to recover from an
>   observed change to the active entry's pin count
>
> This is part of XSA-226.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel