Re: [Xen-devel] [PATCH v1 08/13] tools: create general interfaces to support psr allocation features

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Tue, 2017-08-22 at 10:38 +0800, Yi Sun wrote:
> On 17-08-21 18:12:18, Chao Peng wrote:
> > 
> > 
> > > 
> > >   * mode: C
> > > diff --git a/tools/libxl/libxl_types.idl
> > > b/tools/libxl/libxl_types.idl
> > > index 6e80d36..10d317b 100644
> > > --- a/tools/libxl/libxl_types.idl
> > > +++ b/tools/libxl/libxl_types.idl
> > > @@ -977,6 +977,7 @@ libxl_psr_cbm_type =
> > > Enumeration("psr_cbm_type", [
> > >      (2, "L3_CBM_CODE"),
> > >      (3, "L3_CBM_DATA"),
> > >      (4, "L2_CBM"),
> > > +    (5, "MBA_THRTL"),
> > 
> > This is not quite appropriate as MBA_THRTL is actually not a
> > 'cbm_type'.
> > 
> MBA_THRTL is not 'cbm_type'. But I do not want to create a new generic
> value type structure here. It looks redundant. So, I use the
> 'psr_cbm_type'
> to include MBA too.

I don't strongly insist on it. If others don't object, I'm OK with it.

Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel