Re: [Xen-devel] [PATCH v3 22/52] xen/arch/x86/x86_64/mmconfig-shared.c: let custom parameter parsing routines return errno

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.08.17 at 14:51, <jgross@xxxxxxxx> wrote:
> --- a/xen/arch/x86/x86_64/mmconfig-shared.c
> +++ b/xen/arch/x86/x86_64/mmconfig-shared.c
> @@ -28,22 +28,35 @@
>  
>  unsigned int pci_probe = PCI_PROBE_CONF1 | PCI_PROBE_MMCONF;
>  
> -static void __init parse_mmcfg(char *s)
> +static int __init parse_mmcfg(const char *s)
>  {
> -    char *ss;
> +    const char *ss;
> +    int rc = 0;
>  
>      do {
>          ss = strchr(s, ',');
> -        if ( ss )
> -            *ss = '\0';
> +        if ( !ss )
> +            ss = strchr(s, '\0');
>  
> -        if ( !parse_bool(s) )
> +        switch ( parse_bool(s) ) {

Style. With this corrected
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel