Re: [Xen-devel] [PATCH 02/27] xen/x86: srat: Don't check alloc_boot_pages return

[Andre Przywara <andre.przywara@xxxxxxx>]

Hi,

On 14/08/17 15:23, Julien Grall wrote:
> alloc_boot_pages will panic if it is not possible to allocate. So the
> check in the caller is pointless.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

Thanks,
Andre.

> ---
> 
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
>  xen/arch/x86/srat.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c
> index cd1283e58c..95660a9bbc 100644
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -194,11 +194,6 @@ void __init acpi_numa_slit_init(struct acpi_table_slit 
> *slit)
>               return;
>       }
>       mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1);
> -     if (!mfn) {
> -             printk(KERN_ERR "ACPI: Unable to allocate memory for "
> -                    "saving ACPI SLIT numa information.\n");
> -             return;
> -     }
>       acpi_slit = mfn_to_virt(mfn);
>       memcpy(acpi_slit, slit, slit->header.length);
>  }
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel