Re: [Xen-devel] [PATCH 03/27] xen/x86: mm: Don't check alloc_boot_pages return

[Julien Grall <julien.grall@xxxxxxx>]

On 22/08/17 12:28, Andre Przywara wrote:
> Hi,
Hi Andre,

> On 14/08/17 15:23, Julien Grall wrote:
> > The only way alloc_boot_pages will return 0 is during the error case.
> This statement is not true. If alloc_boot_pages() returns, it has
> succeeded. Returning 0 is nothing special.
>
> > Although, Xen will panic in the error path. So the check in the caller
> > is pointless.
> >
> > Looking at the loop, my understanding is it will try to allocate in
> > smaller chunk if a bigger chunk fail. Given that alloc_boot_pages can
> > never check, the loop seems unecessary.
> Agreed, the algorithm doesn't work with (current) implementation of
> alloc_boot_pages(), so the patch is valid.
>
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Given that you adjust the commit message:
>
> Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
The first 3 patches were already committed a few days ago, so we would 
have to stick with the current message.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel