Re: [Xen-devel] [PATCH V2 8/25] tools/libxl: Add a user configurable parameter to control vIOMMU attributes

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Aug 23, 2017 at 10:46:13AM +0800, Lan Tianyu wrote:
> On 2017年08月22日 21:19, Wei Liu wrote:
> >> +=over 4
> >> > +
> >> > +=item B<KEY=VALUE>
> >> > +
> >> > +Possible B<KEY>s are:
> >> > +
> >> > +=over 4
> >> > +
> >> > +=item B<type="STRING">
> >> > +
> >> > +Currently there is only one valid type:
> >> > +
> >> > +(x86 only) "intel_vtd" means providing a emulated Intel VT-d to the 
> >> > guest.
> >> > +
> >> > +=item B<intremap=BOOLEAN>
> >> > +
> >> > +Specifies whether the vIOMMU should support interrupt remapping
> >> > +and default 'true'.
> >> > +
> >> > +=item B<x2apic=BOOLEAN>
> >> > +
> >> > +Specifies whether the vIOMMU should support x2apic mode and default 
> >> > 'true'.
> >> > +Only valid for "intel_vtd".
> > Why not expose base address and length as well?
> 
> "base address" and "length" of vIOMMU register region is low level
> vIOMMU configuration. I am afraid users is vary hard to determine which
> region is suitable for vIOMMU and doesn't conflict with other device model.

That's fair. Assuming those two values are hardware specific (as I read
in another sub-thread) I'm fine with not exposing them (should they be
needed at all).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel