Re: [Xen-devel] [PATCH 3/3] x86/mm: Introduce and use l?e_{get, from}_mfn()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 24/08/17 14:32, Jan Beulich wrote:
>>>> On 24.08.17 at 15:14, <andrew.cooper3@xxxxxxxxxx> wrote:
>> This avoids the explicit boxing/unboxing of mfn_t in relevant codepaths.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with one optional adjustment:
>
>> --- a/xen/arch/x86/mm/p2m-pt.c
>> +++ b/xen/arch/x86/mm/p2m-pt.c
>> @@ -162,7 +162,7 @@ p2m_free_entry(struct p2m_domain *p2m, l1_pgentry_t 
>> *p2m_entry, int page_order)
>>  
>>      if ( page_order > PAGE_ORDER_2M )
>>      {
>> -        l1_pgentry_t *l3_table = 
>> map_domain_page(_mfn(l1e_get_pfn(*p2m_entry)));
>> +        l1_pgentry_t *l3_table = map_domain_page(l1e_get_mfn(*p2m_entry));
>>          for ( int i = 0; i < L3_PAGETABLE_ENTRIES; i++ )
> Mind adding the missing blank line here?

Will do.

I also see I can drop a pair of brackets from the map_l?t_from_l?e()
changes, which I was planning to do.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel