Re: [Xen-devel] [PATCH v2 REPOST 01/12] [x86|arm]: remove code duplication

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 24 August 2017 15:13
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>; Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>;
> xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 REPOST 01/12] [x86|arm]: remove code duplication
> 
> >>> On 22.08.17 at 16:50, <paul.durrant@xxxxxxxxxx> wrote:
> > There is a substantial amount of code duplicated between the x86 and arm
> > implementations of mm.c:xenmem_add_to_physmap_one() for
> > XENMAPSPACE_grant_table. Also, the code in question looks like it really
> > should be in common/grant_table.c
> >
> > This patch introduces a new function in common/grant_table.c to get the
> mfn
> > of a specified frame in the grant table of a specified guest, and calls to
> > that from the arch-specific code in mm.c.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> This would need re-basing over the XSA-235 fix, but I prefer
> Jürgen's similar change, as it retains the present locking
> properties better on ARM.

That's ok. I'm happy to rebase on that once it is committed.

  Paul

> 
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel