Re: [Xen-devel] [PATCH] x86/EFI: warn about r/o sections requiring relocations

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.08.17 at 10:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 25/08/2017 09:07, Jan Beulich wrote:
>> --- a/xen/arch/x86/xen.lds.S
>> +++ b/xen/arch/x86/xen.lds.S
>> @@ -155,7 +155,11 @@ SECTIONS
>>    __2M_init_start = .;         /* Start of 2M superpages, mapped RWX (boot 
>> only). */
>>    . = ALIGN(PAGE_SIZE);             /* Init code and data */
>>    __init_begin = .;
>> +#ifndef EFI
>>    .init.text : {
>> +#else
>> +  .init : {
>> +#endif
> 
> Why special case these for EFI?  Everything else in the boot path treats
> init as one single blob.
> 
> I don't see an issue with merging them in the non-EFI build as well,
> which would avoid this #ifdefary

I could certainly do that - I merely wanted to affect the non-EFI
case as little as possible.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel