Re: [Xen-devel] [PATCH v7] x86/hvm: Allow guest_request vm_events coming from userspace

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Mon, Aug 28, 2017 at 5:10 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 28.08.17 at 11:38, <aisaila@xxxxxxxxxxxxxxx> wrote:
>> In some introspection usecases, an in-guest agent needs to communicate
>> with the external introspection agent.  An existing mechanism is
>> HVMOP_guest_request_vm_event, but this is restricted to kernel usecases
>> like all other hypercalls.
>>
>> Introduce a mechanism whereby the introspection agent can whitelist the
>> use of HVMOP_guest_request_vm_event directly from userspace.
>>
>> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
>
> For the parts it is applicable to:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> I'd like to note though that I find it a little odd for &d->arch to be
> passed to a hook, instead of just d. But it'll be the maintainers of
> that code to approve (or not) of that.
>

Indeed, I don't see d->arch being passed like this anywhere else
either. I don't think it breaks anything but for stylistic reasons it
might be better to conform here too.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel