Re: [Xen-devel] [PATCH v5] hvmloader, libxl: use the correct ACPI settings depending on device model

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Aug 30, 2017 at 01:52:24PM +0100, Igor Druzhinin wrote:
> We need to choose ACPI tables properly depending on the device
> model version we are running. Previously, this decision was
> made by BIOS type specific code in hvmloader, e.g. always load
> QEMU traditional specific tables if it's ROMBIOS and always
> load QEMU Xen specific tables if it's SeaBIOS.
> 
> This change saves this behavior (for compatibility) but adds
> an additional way (xenstore key) to specify the correct
> device model if we happen to run a non-default one. Toolstack
> bit makes use of it.
> 
> The enforcement of BIOS type depending on QEMU version will
> be lifted later when the rest of ROMBIOS compatibility fixes
> are in place.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 1158303..4f13b69 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -451,7 +451,7 @@ int libxl__domain_build(libxl__gc *gc,
>          vments[4] = "start_time";
>          vments[5] = GCSPRINTF("%lu.%02d", 
> start_time.tv_sec,(int)start_time.tv_usec/10000);
>  
> -        localents = libxl__calloc(gc, 11, sizeof(char *));
> +        localents = libxl__calloc(gc, 13, sizeof(char *));
>          i = 0;
>          localents[i++] = "platform/acpi";
>          localents[i++] = libxl__acpi_defbool_val(info) ? "1" : "0";
> @@ -472,6 +472,8 @@ int libxl__domain_build(libxl__gc *gc,
>                                     info->u.hvm.mmio_hole_memkb << 10);
>              }
>          }
> +        localents[i++] = "platform/device-model";
> +        localents[i++] = (char 
> *)libxl_device_model_version_to_string(info->device_model_version);

This line is too long.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel