Re: [Xen-devel] [PATCH v2] tools: remove unnecessary PSR macros

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 04, 2017 at 05:10:21PM +0800, Yi Sun wrote:
> On 17-09-04 09:49:40, Wei Liu wrote:
> > On Mon, Sep 04, 2017 at 11:08:56AM +0800, Yi Sun wrote:
> > > The libxl interfaces and related functions are not necessary to be 
> > > included by
> > > 'LIBXL_HAVE_PSR_CMT' and 'LIBXL_HAVE_PSR_CAT'. So remove them.
> > > 
> > > Suggested-by: Roger Pau Monn? <roger.pau@xxxxxxxxxx>
> > > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> > 
> > Thinking about this a bit more, it is not that simple.
> > 
> > LIBXL_HAVE_PSR_CMT is enclosed by __i386__ and __x86_64__, libxl_psr.o
> > is only built on x86.
> > 
> > I'm afraid we do need these macros in libxl and xl otherwise arm build
> > is going to be broken.
> 
> Good point. Shall we use '#if defined(__i386__) || defined(__x86_64__)' to
> include all PSR interfaces?

Yes. There is no arm counterpart as far as I can tell.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel