Re: [Xen-devel] [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test

[Bruce Richardson <bruce.richardson@xxxxxxxxx>]

On Wed, Aug 30, 2017 at 06:10:31PM +0000, Jianfeng Tan wrote:
> Signed-off-by: Jianfeng Tan <jianfeng.tan@xxxxxxxxx>
> ---
>  app/test-pmd/testpmd.c              |  2 +-
>  examples/ip_pipeline/app.h          |  4 --
>  examples/ip_pipeline/config_parse.c | 19 ---------
>  examples/ip_pipeline/init.c         |  5 ---
>  examples/kni/main.c                 |  3 --
>  test/test/process.h                 | 10 -----
>  test/test/test.c                    |  4 --
>  test/test/test_eal_flags.c          | 81 
> -------------------------------------
>  8 files changed, 1 insertion(+), 127 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index f8d02ae..d9c785c 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -494,7 +494,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
>               "create a new mbuf pool <%s>: n=%u, size=%u, socket=%u\n",
>               pool_name, nb_mbuf, mbuf_seg_size, socket_id);
>  
> -     /* if the former XEN allocation failed fall back to normal allocation */
> +     /* if the former allocation failed fall back to normal allocation */
>       if (rte_mp == NULL) {
>               if (mp_anon != 0) {
>                       rte_mp = rte_mempool_create_empty(pool_name, nb_mbuf,

There is no former allocation here, so I think the previous patch, which
removed the #ifdef block should also remove this comment entirely, and
the "if (rte_mp == NULL)" too


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel