Re: [Xen-devel] [PATCH 6/7] x86/mm: Combine {destroy, replace}_grant_{pte, va}_mapping()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.17 at 14:14, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -4136,12 +3959,14 @@ int replace_grant_pv_mapping(uint64_t addr, unsigned 
> long frame,
>  {
>      struct vcpu *curr = current;
>      struct domain *currd = curr->domain;
> -    l1_pgentry_t ol1e;
> -    int rc;
> +    l1_pgentry_t nl1e = l1e_empty(), ol1e, *pl1e;
> +    struct page_info *page;
> +    mfn_t gl1mfn;
> +    int rc = GNTST_general_error;
>      unsigned int grant_pte_flags = grant_to_pte_flags(flags, 0);
>  
>      /*
> -     * On top of the explicit settings done by create_grant_host_mapping()
> +     * On top of the explicit settings done by create_pv_host_mapping()

create_grant_pv_mapping()

Other than that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel