Re: [Xen-devel] [PATCH v2 3/7] xen/arm: traps: Export a bunch of helpers to handle emulation

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 09/12/2017 10:26 PM, Stefano Stabellini wrote:
> > +int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr);
> > +
> > +void advance_pc(struct cpu_user_regs *regs, const union hsr hsr);
> > +
> > +void inject_undef_exception(struct cpu_user_regs *regs, const union hsr hsr);
> > +
> > +void handle_raz_wi(struct cpu_user_regs *regs, int regidx, bool read,
> > +                   const union hsr hsr, int min_el);
> > +
> > +void handle_wo_wi(struct cpu_user_regs *regs, int regidx, bool read,
> > +                  const union hsr hsr, int min_el);
> > +
> > +void handle_ro_raz(struct cpu_user_regs *regs, int regidx, bool read,
> > +                   const union hsr hsr, int min_el);
> Could you please copy or move the simple one-line comments we have in
> traps.c here as well to describe these functions? Such as "Read only as
> read as zero" and "Read as zero and write ignore".
I will do that.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel