Re: [Xen-devel] [PATCH v4 05/11] arm: add SMCCC protocol definitions.

[Julien Grall <julien.grall@xxxxxxx>]

On 08/28/2017 09:28 PM, Volodymyr Babchuk wrote:
> Hi Julien,
Hi,

> On 24.08.17 18:00, Julien Grall wrote:
> > Hi Volodymyr,
> >
> > Title: No need for the full stop.
> >
> > On 21/08/17 21:27, Volodymyr Babchuk wrote:
> > > This patch adds generic definitions used in ARM SMC call convention.
> > > Those definitions was taken from linux header arm-smccc.h, extended
> > > and formatted according to XEN coding style.
> > >
> > > They can be used by both SMCCC clients (like PSCI) and by SMCCC
> > > servers (like vPSCI or upcoming generic SMCCC handler).
> > >
> > > Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> > > ---
> > >  xen/include/asm-arm/smccc.h | 92 
> > > +++++++++++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 92 insertions(+)
> > >  create mode 100644 xen/include/asm-arm/smccc.h
> > >
> > > diff --git a/xen/include/asm-arm/smccc.h b/xen/include/asm-arm/smccc.h
> > > new file mode 100644
> > > index 0000000..67da3fb
> > > --- /dev/null
> > > +++ b/xen/include/asm-arm/smccc.h
> > > @@ -0,0 +1,92 @@
> > > +/*
> > > + * Copyright (c) 2015, Linaro Limited
> > Linaro? Where does this code come from?
>  From the linux kernel. I think, I mentioned that in previous comments.
> But this code was extended by me. And now there will be more changes.
> Should I add remark about code origin somewhere?
Yes, the origin of code (repo + commit ID) + changes you made at least 
in the commit message.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel