Re: [Xen-devel] [PATCH 05/14] fuzz/x86_emulate: Improve failure descriptions in x86_emulate harness

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Aug 25, 2017 at 05:43:34PM +0100, George Dunlap wrote:
> - Print the symbolic name rather than the number
> - Explicitly state when data_read() fails due to EOI
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> ---
>  tools/fuzz/x86_instruction_emulator/fuzz-emul.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c 
> b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
> index 48a879cc88..7f9a369421 100644
> --- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
> +++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c
> @@ -52,6 +52,14 @@ struct fuzz_state
>      struct x86_emulate_ops ops;
>  };
>  
> +char *x86emul_return_string[] = {
> +    [X86EMUL_OKAY]="X86EMUL_OKAY",
> +    [X86EMUL_UNHANDLEABLE]="X86EMUL_UNHANDLEABLE",
> +    [X86EMUL_EXCEPTION]="X86EMUL_EXCEPTION",
> +    [X86EMUL_RETRY]="X86EMUL_RETRY",
> +    [X86EMUL_DONE]="X86EMUL_DONE",

Can you please add spaces around "=" ?

With that fixed:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel