Re: [Xen-devel] [PATCH 08/22] xentoolcore_restrict_all: "Implement" for libxencall

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 15, 2017 at 07:48:45PM +0100, Ian Jackson wrote:
> +static int all_restrict_cb(Xentoolcore__Active_Handle *ah, uint32_t domid) {
> +    xencall_handle *xcall = CONTAINER_OF(ah, *xcall, tc_ah);
> +    int nullfd = -1, r;
> +
> +    if (xcall->fd < 0)
> +        /* just in case */
> +        return 0;
> +
> +    /*
> +     * We don't implement a restrict function.  We neuter the fd by
> +     * dup'ing /dev/null onto it.  This is better than closing it,
> +     * because it does not involve locking against concurrent uses
> +     * of xencall in other threads.
> +     */
> +    nullfd = open("/dev/null",O_RDONLY);

Space after "," please.

With that fixed:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel