Re: [Xen-devel] [PATCH v3 02/15] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-09-19 09:03:38, Roger Pau Monn� wrote:
> On Tue, Sep 05, 2017 at 05:32:24PM +0800, Yi Sun wrote:
> > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
> > index 0669c31..a953157 100644
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > -struct xen_domctl_psr_cat_op {
> > -#define XEN_DOMCTL_PSR_CAT_OP_SET_L3_CBM     0
> > -#define XEN_DOMCTL_PSR_CAT_OP_GET_L3_CBM     1
> > -#define XEN_DOMCTL_PSR_CAT_OP_SET_L3_CODE    2
> > -#define XEN_DOMCTL_PSR_CAT_OP_SET_L3_DATA    3
> > -#define XEN_DOMCTL_PSR_CAT_OP_GET_L3_CODE    4
> > -#define XEN_DOMCTL_PSR_CAT_OP_GET_L3_DATA    5
> > -#define XEN_DOMCTL_PSR_CAT_OP_SET_L2_CBM     6
> > -#define XEN_DOMCTL_PSR_CAT_OP_GET_L2_CBM     7
> > +struct xen_domctl_psr_alloc {
> > +#define XEN_DOMCTL_PSR_ALLOC_SET_L3_CBM     0
> > +#define XEN_DOMCTL_PSR_ALLOC_GET_L3_CBM     1
> > +#define XEN_DOMCTL_PSR_ALLOC_SET_L3_CODE    2
> > +#define XEN_DOMCTL_PSR_ALLOC_SET_L3_DATA    3
> > +#define XEN_DOMCTL_PSR_ALLOC_GET_L3_CODE    4
> > +#define XEN_DOMCTL_PSR_ALLOC_GET_L3_DATA    5
> > +#define XEN_DOMCTL_PSR_ALLOC_SET_L2_CBM     6
> > +#define XEN_DOMCTL_PSR_ALLOC_GET_L2_CBM     7
> 
> IMHO, the _ALLOC_ part is not needed here, ALLOC_GET/SET seems quite
> weird to me, and redundant, since the type itself already contains
> _alloc).

Ok.

> 
> >      uint32_t cmd;       /* IN: XEN_DOMCTL_PSR_CAT_OP_* */
> 
> This comments needs fixing.
> 
Yes, thanks!

[...]

> > diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> > index 9e51af6..4759b10 100644
> > --- a/xen/include/public/sysctl.h
> > +++ b/xen/include/public/sysctl.h
> > @@ -36,7 +36,7 @@
> >  #include "physdev.h"
> >  #include "tmem.h"
> >  
> > -#define XEN_SYSCTL_INTERFACE_VERSION 0x0000000F
> > +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000010
> >  
> >  /*
> >   * Read console content from Xen buffer ring.
> > @@ -743,22 +743,22 @@ struct xen_sysctl_pcitopoinfo {
> >  typedef struct xen_sysctl_pcitopoinfo xen_sysctl_pcitopoinfo_t;
> >  DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t);
> >  
> > -#define XEN_SYSCTL_PSR_CAT_get_l3_info               0
> > -#define XEN_SYSCTL_PSR_CAT_get_l2_info               1
> > -struct xen_sysctl_psr_cat_op {
> > +#define XEN_SYSCTL_PSR_ALLOC_get_l3_info               0
> > +#define XEN_SYSCTL_PSR_ALLOC_get_l2_info               1
> 
> Same here, I would drop the _ALLOC_.
> 
Ok.

> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel