[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: credit2: fix spinlock irq-safety violation



>>> On 20.09.17 at 13:44, <dario.faggioli@xxxxxxxxxx> wrote:
> IAC, if you're concerned about that, I'd much rather put both
> kill_timer() and xfree() before the critical section, rather than
> after, like in the attached patch.

Hmm, killing the timer upfront is certainly fine, but is freeing the
data before removing the element from the list safe not only
currently, but also going forward?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.