[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 14/24] xen/arm: page: Use directly BUFFERABLE and drop DEV_WC



Hi,

On 20/09/17 00:33, Stefano Stabellini wrote:
On Tue, 12 Sep 2017, Julien Grall wrote:
DEV_WC is only used for PAGE_HYPERVISOR_WC and does not bring much
improvement.

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>

---

     Changes in v2:
         - Remove DEV_WC from the comment as well
         - Add Andre's reviewed-by
---
  xen/include/asm-arm/page.h | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index d7939bb944..ee0422579b 100644
--- a/xen/include/asm-arm/page.h
+++ b/xen/include/asm-arm/page.h
@@ -34,8 +34,6 @@
   *   ??            101
   *   reserved      110
   *   WRITEALLOC    111   1111 1111  -- Write-back write-allocate
- *
- *   DEV_WC        001   (== BUFFERABLE)
   */
  #define MAIR0VAL 0xeeaa4400
  #define MAIR1VAL 0xff000004

Please update MAIR0VAL

Same remark as patch #13... DEV_WC is just an alias as (== BUFFERABLE) show it.

Cheers,



@@ -55,11 +53,10 @@
  #define WRITEBACK     0x3
  #define DEV_SHARED    0x4
  #define WRITEALLOC    0x7
-#define DEV_WC        BUFFERABLE
#define PAGE_HYPERVISOR (WRITEALLOC)
  #define PAGE_HYPERVISOR_NOCACHE (DEV_SHARED)
-#define PAGE_HYPERVISOR_WC      (DEV_WC)
+#define PAGE_HYPERVISOR_WC      (BUFFERABLE)
/*
   * Defines for changing the hypervisor PTE .ro and .nx bits. This is only to 
be
--
2.11.0


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.