[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libxc: remove stale error check for domain size in xc_sr_save_x86_hvm.c



On 26/09/17 09:41, Andrew Cooper wrote:
> On 26/09/2017 08:33, Juergen Gross wrote:
>> Long ago domains to be saved were limited to 1TB size due to the
>> migration stream v1 limitations which used a 32 bit value for the
>> PFN and the frame type (4 bits) leaving only 28 bits for the PFN.
>>
>> Migration stream V2 uses a 64 bit value for this purpose, so there
>> is no need to refuse saving (or migrating) domains larger than 1 TB.
>>
>> Remove the related test in xc_sr_save_x86_hvm.c
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> 
> Sorry, but this still serves a very real purpose.  Without it, you will
> crash a 32bit toolstack trying to migrate a large domain, due to virtual
> address space exhaustion.

So would you be fine with doing the check for 32 bit toolstack only?

Eventually on the receiver side, too?


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.