Re: [Xen-devel] [PATCH v3 10/22] libxl: add PVH support to domain creation

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Sep 27, 2017 at 02:28:11PM +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v3 10/22] libxl: add PVH support to domain 
> creation"):
> > Remove the device model "none" support from domain creation and
> > introduce support for PVH.
> 
> This is a backwards-incompatible change, which at the very least
> requires justification.  The facility seems to have been introduced in
> 
>   libxl: allow the creation of HVM domains without a device model.
>   5ca88cb7582a19636646c1a39c739fdbcaf3362a
> 
> which was part of the original PVH2 work, I think.  I'm not sure how
> explicitly we need to have marked the interface as unstable but we
> probably did somewhere.  Perhaps you could introduce an appropriate
> reference in the commit message ?

What about adding:

Setting device model to none was never supported since it was an
unstable interface used while transitioning from PVHv1 to PVHv2.

Now that PVHv1 has been finally removed and that a supported
interface for PVHv2 is being added this option is no longer necessary,
hence it's removed.

I can also add:

It might be possible to re-introduce it in the future with a proper
implementation, in order to create a HVM guest without a device model,
which is slightly different from a PVHv2 guest.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel