Re: [Xen-devel] [PATCH v10 09/11] xen: make grant resource limits per domain

[Julien Grall <julien.grall@xxxxxxx>]

Hi Juergen,

On 09/25/2017 11:00 AM, Juergen Gross wrote:
> diff --git a/xen/include/asm-arm/grant_table.h 
> b/xen/include/asm-arm/grant_table.h
> index 30db2d1616..bcdeada9ca 100644
> --- a/xen/include/asm-arm/grant_table.h
> +++ b/xen/include/asm-arm/grant_table.h
> @@ -2,9 +2,11 @@
>   #define __ASM_GRANT_TABLE_H__
>   
>   #include <xen/grant_table.h>
> +#include <xen/kernel.h>
> +#include <xen/pfn.h>
>   #include <xen/sched.h>
>   
> -#define INITIAL_NR_GRANT_FRAMES 4
> +#define INITIAL_NR_GRANT_FRAMES 1U
>   
>   struct grant_table_arch {
>       gfn_t *gfn;
> @@ -26,9 +28,14 @@ static inline int replace_grant_supported(void)
>       return 1;
>   }
>   
> +static inline unsigned int gnttab_dom0_max(void)
> +{
> +    return PFN_DOWN(_etext - _stext);
> +}
I think you need a comment on top of this function explaining why you 
return this value. Re-using part of the comment in find_gnttab_region 
would be fine to me.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel