Re: [Xen-devel] [PATCH v3 08/15] tools: create general interfaces to support psr allocation features

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 22, 2017 at 03:01:42PM +0800, Chao Peng wrote:
> On Tue, 2017-09-19 at 11:04 +0100, Roger Pau Monné wrote:
> > On Tue, Sep 05, 2017 at 05:32:30PM +0800, Yi Sun wrote:
> > > 
> > > This patch creates general interfaces in libxl to support all psr
> > > allocation features.
> > > 
> > > Add 'LIBXL_HAVE_PSR_GENERIC' to indicate interface change.
> > > 
> > > Please note, the functionality cannot work until later patches
> > > are applied.
> > > 
> > > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>
> > > ---
> > > v3:
> > >     - change 'LIBXL_HAVE_PSR_MBA' to 'LIBXL_HAVE_PSR_GENERIC'.
> > >       (suggested by Roger Pau Monné)
> > >     - 'typedef enum libxl_psr_cbm_type libxl_psr_type;' in libxl.h.
> > >       (suggested by Roger Pau Monné and Wei Liu)
> > >     - change 'libxl_psr_cbm_type' to 'libxl_psr_type' in newly
> > > defined
> > >       interfaces.
> > >       (suggested by Roger Pau Monné)
> > > v2:
> > >     - remove '_INFO' in 'libxl_psr_feat_type' and make corresponding
> > >       changes in 'libxl_psr_hw_info'.
> > >       (suggested by Chao Peng)
> > > ---
> > >  tools/libxl/libxl.h         | 33 +++++++++++++++++++++++++++++++++
> > >  tools/libxl/libxl_psr.c     | 25 +++++++++++++++++++++++++
> > >  tools/libxl/libxl_types.idl | 22 ++++++++++++++++++++++
> > >  3 files changed, 80 insertions(+)
> > > 
> > > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> > > index 484b5b7..9744087 100644
> > > --- a/tools/libxl/libxl.h
> > > +++ b/tools/libxl/libxl.h
> > > @@ -931,6 +931,13 @@ void libxl_mac_copy(libxl_ctx *ctx, libxl_mac
> > > *dst, const libxl_mac *src);
> > >  #define LIBXL_HAVE_PSR_L2_CAT 1
> > >  
> > >  /*
> > > + * LIBXL_HAVE_PSR_GENERIC
> > > + *
> > > + * If this is defined, the Memory Bandwidth Allocation feature is
> > > supported.
> > 
> > You should also mention that if this is defined the following public
> > functions are available:
> > 
> > libxl_psr_{set/get}_val
> > libxl_psr_get_hw_info
> > libxl_psr_hw_info_list_free
> > 
> 
> I'm just wondering what macro we will use when more PSR generic routines
> are needed in the future releases. LIBXL_HAVE_PSR_GENERIC2?

GENERIC2 sounds horrible but if we have to, so be it. But I suppose we
can always think of better names. We shall cross the bridge when we gets
there.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel