Re: [Xen-devel] [PATCH v13 1/3] x86emul: New return code for unimplemented instruction

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 10/02/2017 02:43 PM, George Dunlap wrote:
> On 09/25/2017 01:03 PM, Petre Pircalabu wrote:
>> Enforce the distinction between an instruction not implemented by the
>> emulator and the failure to emulate that instruction by defining a new
>> return code, X86EMUL_UNIMPLEMENTED.
>>
>> This value should only be returned by the core emulator only if it fails to
>> properly decode the current instruction's opcode, and not by any of other
>> functions, such as the x86_emulate_ops or the hvm_io_ops callbacks.
> 
> Oh, minor comment:  Should this paragraph be changed to match the
> comment in the patch itself?  I.e.:
> 
> "This value should only be returned by the core emulator when a valid
> opcode is found but the execution logic for that instruction is missing.
> It should NOT be returned by any of the x86_emulate_ops callbacks."

I'll do this on check-in if I don't hear any objections by tomorrow.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel