[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 08/10] arm: PSCI: use definitions provided by asm/smccc.h



Hi Julien,

On 03.10.17 16:18, Julien Grall wrote:
Hi Volodymyr,

On 21/09/17 21:00, Volodymyr Babchuk wrote:
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 34ee97e..be4e8e6 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -31,9 +31,9 @@
   * (native-width) function ID.
   */
  #ifdef CONFIG_ARM_64
-#define PSCI_0_2_FN_NATIVE(name)    PSCI_0_2_FN64_##name
+#define PSCI_0_2_FN_NATIVE(name)        PSCI_0_2_FN64(name)

While I am ok that you replace the tabulation by space, I believe you are still using a double tabulations.

Xen is using 4 spaces tabulation and not 8.
Ah, I see. I just tried to leave indentation as it was before, just changed tab to spaces. Okay, I'll reduce spaces to 4.


  #else
-#define PSCI_0_2_FN_NATIVE(name)    PSCI_0_2_FN_##name
+#define PSCI_0_2_FN_NATIVE(name)        PSCI_0_2_FN32(name)

Ditto.

  #endif

Cheers,


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.