Re: [Xen-devel] [PATCH 3/4] xen/ubsan: Implement __ubsan_handle_nonnull_arg()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.10.17 at 20:07, <andrew.cooper3@xxxxxxxxxx> wrote:
> This hook appears to be missing from the Linux ubsan implemention.  This patch
> is a forward port of https://lkml.org/lkml/2014/10/20/182 
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Patch 2 as well as this one
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit preferably with ...

> --- a/xen/common/ubsan/ubsan.c
> +++ b/xen/common/ubsan/ubsan.c
> @@ -328,6 +328,26 @@ void __ubsan_handle_type_mismatch(struct 
> type_mismatch_data *data,
>  }
>  EXPORT_SYMBOL(__ubsan_handle_type_mismatch);
>  
> +void __ubsan_handle_nonnull_arg(struct nonnull_arg_data *data)
> +{
> +     unsigned long flags;
> +
> +     if (suppress_report(&data->location))
> +             return;
> +
> +     ubsan_prologue(&data->location, &flags);
> +
> +     pr_err("null pointer passed as argument %d, declared with nonnull 
> attribute\n",
> +            data->arg_index);
> +
> +     if (location_is_valid(&data->attr_location))
> +             print_source_location("nonnull attribute declared in ",
> +                                   &data->attr_location);
> +
> +     ubsan_epilogue(&flags);
> +}
> +EXPORT_SYMBOL(__ubsan_handle_nonnull_arg);

... all the EXPORT_SYMBOL()s dropped - I was really hoping we
could get ris of what we've left instead of adding new ones.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel