Re: [Xen-devel] [PATCH v2 9/9] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 05/10/17 18:42, Julien Grall wrote:
> @@ -1114,7 +1115,7 @@ int arch_set_info_guest(
>          l4_pgentry_t *l4tab;
>  
>          l4tab = 
> map_domain_page(_mfn(pagetable_get_pfn(v->arch.guest_table)));
> -        *l4tab = l4e_from_pfn(page_to_mfn(cr3_page),
> +        *l4tab = l4e_from_pfn(mfn_x(page_to_mfn(cr3_page)),

Apologies for missing this before.  You can use l4e_from_mfn() and avoid
the unboxing.

Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 
Everything else seems in order (but I've only skimmed it).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel