Re: [Xen-devel] [PATCH for-4.10 1/5] tools/dombuilder: Drop more PVH v1 leftovers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Oct 06, 2017 at 09:33:52AM +0000, Wei Liu wrote:
> On Fri, Oct 06, 2017 at 10:26:03AM +0100, Roger Pau Monné wrote:
> > On Thu, Oct 05, 2017 at 06:23:39PM +0000, Andrew Cooper wrote:
> > > alloc_magic_pages() is renamed to alloc_magic_pages_pv() to mirror its
> > > alloc_magic_pages_hvm() counterpart.  Delete a redundant comment, 
> > > introduce
> > > some newlines clarity, and remove a logically dead allocation of shared 
> > > info.
> > > 
> > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > 
> > > ---
> > > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > > CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > CC: Julien Grall <julien.grall@xxxxxxx>
> > > ---
> > >  tools/libxc/xc_dom_x86.c | 16 ++++++----------
> > >  1 file changed, 6 insertions(+), 10 deletions(-)
> > > 
> > > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> > > index cb68efc..885ca1b 100644
> > > --- a/tools/libxc/xc_dom_x86.c
> > > +++ b/tools/libxc/xc_dom_x86.c
> > > @@ -534,24 +534,20 @@ static int alloc_p2m_list_x86_64(struct 
> > > xc_dom_image *dom)
> > >  
> > >  /* 
> > > ------------------------------------------------------------------------ 
> > > */
> > >  
> > > -static int alloc_magic_pages(struct xc_dom_image *dom)
> > > +static int alloc_magic_pages_pv(struct xc_dom_image *dom)
> > >  {
> > > -    /* allocate special pages */
> > >      dom->start_info_pfn = xc_dom_alloc_page(dom, "start info");
> > >      if ( dom->start_info_pfn == INVALID_PFN )
> > >          return -1;
> > 
> > Maybe those errors paths should set errno = ENOMEM?
> 
> I believe the actual allocation function already does that.

Doesn't seem like xc_dom_alloc_page or xc_dom_chk_alloc_pages set
errno at all (or I'm not able to find it), but in any case it should
be set there rather than here. libxc is a disaster in this regard I'm
afraid.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel