Re: [Xen-devel] [PATCH v5 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.10.17 at 18:53, <roger.pau@xxxxxxxxxx> wrote:
> On Sat, Sep 30, 2017 at 01:39:12AM +0000, Yi Sun wrote:
>> --- a/xen/arch/x86/domctl.c
>> +++ b/xen/arch/x86/domctl.c
>> @@ -37,6 +37,16 @@
>>  #include <asm/psr.h>
>>  #include <asm/cpuid.h>
>>  
>> +#define domctl_psr_get_val(d, domctl, type, copyback) ({   \
>> +    int r__;                                               \
>> +    uint32_t v__;                                          \
> 
> No '__' in variable names, and missing newline.

Why that? We're disallowing underscores as prefixes, but using
(normally single) trailing underscores for macro local variables is
quite usual, to avoid possible expansion conflicts.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel