Re: [Xen-devel] [PATCH v5 2/5] ARM: ITS: Populate host_its_list from ACPI MADT Table

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Manish,

On 10/10/17 07:16, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
> diff --git a/xen/include/asm-arm/gic_v3_its.h b/xen/include/asm-arm/gic_v3_its.h
> index 1fac1c7..e1be33c 100644
> --- a/xen/include/asm-arm/gic_v3_its.h
> +++ b/xen/include/asm-arm/gic_v3_its.h
> @@ -20,6 +20,7 @@
>   #ifndef __ASM_ARM_ITS_H__
>   #define __ASM_ARM_ITS_H__
>   
> +#define GICV3_ITS_SIZE                  SZ_128K
You still didn't address my comment here... This *must* be moved close
to ITS_DOORBELL_OFFSET as the current place is just random.

>   #define GITS_CTLR                       0x000
>   #define GITS_IIDR                       0x004
>   #define GITS_TYPER                      0x008
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel